Re: [PATCH v4 01/30] accel/tcg: Restrict cpu_handle_halt() to sysemu

[Richard Henderson]

On 9/12/21 10:27 AM, Philippe Mathieu-Daudé wrote:
> Commit 372579427a5 ("tcg: enable thread-per-vCPU") added the following
> comment describing EXCP_HALTED in qemu_tcg_cpu_thread_fn():
>
>      case EXCP_HALTED:
>           /* during start-up the vCPU is reset and the thread is
>            * kicked several times. If we don't ensure we go back
>            * to sleep in the halted state we won't cleanly
>            * start-up when the vCPU is enabled.
>            *
>            * cpu->halted should ensure we sleep in wait_io_event
>            */
>           g_assert(cpu->halted);
>           break;
>
> qemu_wait_io_event() is sysemu-specific, so we can restrict the
> cpu_handle_halt() call in cpu_exec() to system emulation.
>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
> v4: Reduce ifdef'ry to cpu_handle_halt (rth)
> ---
>   accel/tcg/cpu-exec.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~