[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 15/19] hvf: arm: Implement -cpu host
|
From: |
Alexander Graf |
|
Subject: |
Re: [PATCH v8 15/19] hvf: arm: Implement -cpu host |
|
Date: |
Mon, 13 Sep 2021 13:46:32 +0200 |
|
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 |
On 13.09.21 12:52, Peter Maydell wrote:
> On Mon, 13 Sept 2021 at 11:46, Alexander Graf <agraf@csgraf.de> wrote:
>> Why? You only get to this code path if you already selected -accel hvf.
>> If even a simple "create scratch vcpu" syscall failed then, pretty
>> failure when you define -cpu host is the last thing you care about. Any
>> CPU creation would fail.
> General design principle -- low level functions should report
> errors upwards, not barf and exit.
Usually I would agree with you, but here it really does not make sense
and would make the code significantly harder to read.
Alex