Re: [PATCH 02/22] qapi: Stop enforcing "type name should not end in 'Kind'

[Eric Blake]

On Mon, Sep 13, 2021 at 02:39:12PM +0200, Markus Armbruster wrote:
> I'm about to convert simple unions to flat unions, then drop simple
> union support.  The conversion involves making the implict enum types
> explicit.  To reduce churn, I'd like to name them exactly like the
> implicit types they replace.  However, these names are reserved for
> the generator's use.  They won't be once simple unions are gone.  Stop
> enforcing this naming rule now rather than then.

Sounds like a good plan!

> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  scripts/qapi/expr.py                      | 6 +++---
>  tests/qapi-schema/meson.build             | 1 -
>  tests/qapi-schema/reserved-type-kind.err  | 2 --
>  tests/qapi-schema/reserved-type-kind.json | 2 --
>  tests/qapi-schema/reserved-type-kind.out  | 0
>  5 files changed, 3 insertions(+), 8 deletions(-)
>  delete mode 100644 tests/qapi-schema/reserved-type-kind.err
>  delete mode 100644 tests/qapi-schema/reserved-type-kind.json
>  delete mode 100644 tests/qapi-schema/reserved-type-kind.out

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org