[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/22] tests/qapi-schema: Prepare for simple union UserDefLis
From: |
Eric Blake |
Subject: |
Re: [PATCH 11/22] tests/qapi-schema: Prepare for simple union UserDefListUnion removal |
Date: |
Mon, 13 Sep 2021 10:01:13 -0500 |
User-agent: |
NeoMutt/20210205-772-2b4c52 |
On Mon, Sep 13, 2021 at 02:39:21PM +0200, Markus Armbruster wrote:
> Simple unions predate flat unions. Having both complicates the QAPI
> schema language and the QAPI generator. We haven't been using simple
> unions in new code for a long time, because they are less flexible and
> somewhat awkward on the wire.
>
> To prepare for their removal, simple union UserDefListUnion has to go.
> It is used to cover arrays. The next few commits will eliminate its
> uses, and then it gets deleted. As a first step, provide struct
> ArrayStruct for the tests to be rewritten.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> tests/qapi-schema/qapi-schema-test.json | 16 ++++++++++++++++
> tests/qapi-schema/qapi-schema-test.out | 16 ++++++++++++++++
> 2 files changed, 32 insertions(+)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [PATCH 06/22] qapi: Convert simple union MemoryDeviceInfo to flat one, (continued)
- [PATCH 06/22] qapi: Convert simple union MemoryDeviceInfo to flat one, Markus Armbruster, 2021/09/13
- [PATCH 10/22] qapi: Convert simple union TransactionAction to flat one, Markus Armbruster, 2021/09/13
- [PATCH 05/22] qapi: Convert simple union TpmTypeOptions to flat one, Markus Armbruster, 2021/09/13
- [PATCH 04/22] qapi: Convert simple union InputEvent to flat one, Markus Armbruster, 2021/09/13
- [PATCH 12/22] test-qobject-input-visitor: Wean off UserDefListUnion, Markus Armbruster, 2021/09/13
- [PATCH 11/22] tests/qapi-schema: Prepare for simple union UserDefListUnion removal, Markus Armbruster, 2021/09/13
- Re: [PATCH 11/22] tests/qapi-schema: Prepare for simple union UserDefListUnion removal,
Eric Blake <=
- [PATCH 16/22] tests/qapi-schema: Simple union UserDefListUnion is now unused, drop, Markus Armbruster, 2021/09/13
- [PATCH 14/22] test-clone-visitor: Wean off UserDefListUnion, Markus Armbruster, 2021/09/13
- [PATCH 15/22] tests/qapi-schema: Wean off UserDefListUnion, Markus Armbruster, 2021/09/13
- [PATCH 22/22] test-clone-visitor: Correct an accidental rename, Markus Armbruster, 2021/09/13
- [PATCH 01/22] qapi: Tidy up unusual line breaks, Markus Armbruster, 2021/09/13