Re: [PATCH v4 05/16] tcg/s390x: Implement tcg_out_ld/st for vector types

[Richard Henderson]

On 9/14/21 9:46 AM, David Hildenbrand wrote:
> > +static void tcg_out_insn_VRX(TCGContext *s, S390Opcode op, TCGReg v1,
> > +                             TCGReg b2, TCGReg x2, intptr_t d2, int m3)
>
> Is intptr_t really the right type here? Just curious ... I'd have used an uint16_t and 
> asserted "!(d1 & 0xf000)".

It does come from upstream, as part of a host address. If you use uint16_t, the assert 
misses the upper bits being zero because they've been truncated.


r~