[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 07/20] nubus: add trace-events for empty slot accesses
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v2 07/20] nubus: add trace-events for empty slot accesses |
|
Date: |
Wed, 15 Sep 2021 12:42:03 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 9/15/21 12:10 PM, Mark Cave-Ayland wrote:
> Increase the max_access_size to 4 bytes for empty Nubus slot and super slot
> accesses to allow tracing of the Nubus enumeration process by the guest OS.
I forgot to reply to v1, this is OK but I'd rather have 2 different
patches here, tracing first then 32-bit access (your call anyway).
Regardless:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
> hw/nubus/nubus-bus.c | 10 +++++++---
> hw/nubus/trace-events | 7 +++++++
> hw/nubus/trace.h | 1 +
> meson.build | 1 +
> 4 files changed, 16 insertions(+), 3 deletions(-)
> create mode 100644 hw/nubus/trace-events
> create mode 100644 hw/nubus/trace.h
- [PATCH v2 00/20] nubus: bus, device, bridge, IRQ and address space improvements, Mark Cave-Ayland, 2021/09/15
- [PATCH v2 01/20] nubus-device: rename slot_nb variable to slot, Mark Cave-Ayland, 2021/09/15
- [PATCH v2 02/20] nubus-device: expose separate super slot memory region, Mark Cave-Ayland, 2021/09/15
- [PATCH v2 03/20] nubus-device: add device slot parameter, Mark Cave-Ayland, 2021/09/15
- [PATCH v2 05/20] nubus: move slot bitmap checks from NubusDevice realize() to BusClass check_address(), Mark Cave-Ayland, 2021/09/15
- [PATCH v2 06/20] nubus: implement BusClass get_dev_path(), Mark Cave-Ayland, 2021/09/15
- [PATCH v2 07/20] nubus: add trace-events for empty slot accesses, Mark Cave-Ayland, 2021/09/15
- Re: [PATCH v2 07/20] nubus: add trace-events for empty slot accesses,
Philippe Mathieu-Daudé <=
- [PATCH v2 04/20] nubus: use bitmap to manage available slots, Mark Cave-Ayland, 2021/09/15
- [PATCH v2 08/20] nubus: generate bus error when attempting to access empty slots, Mark Cave-Ayland, 2021/09/15
- [PATCH v2 09/20] macfb: don't register declaration ROM, Mark Cave-Ayland, 2021/09/15
- [PATCH v2 10/20] nubus-device: remove nubus_register_rom() and nubus_register_format_block(), Mark Cave-Ayland, 2021/09/15
- [PATCH v2 11/20] nubus-device: add romfile property for loading declaration ROMs, Mark Cave-Ayland, 2021/09/15
- [PATCH v2 12/20] nubus: move nubus to its own 32-bit address space, Mark Cave-Ayland, 2021/09/15
- [PATCH v2 13/20] nubus-bridge: introduce separate NubusBridge structure, Mark Cave-Ayland, 2021/09/15
- [PATCH v2 14/20] mac-nubus-bridge: rename MacNubusState to MacNubusBridge, Mark Cave-Ayland, 2021/09/15