Re: [PATCH v2 20/20] q800: configure nubus available slots for Quadra 800

[Philippe Mathieu-Daudé]

On 9/15/21 12:50 PM, BALATON Zoltan wrote:
> On Wed, 15 Sep 2021, Mark Cave-Ayland wrote:
>> Slot 0x9 is reserved for use by the in-built framebuffer whilst only
>> slots
>> 0xc, 0xd and 0xe physically exist on the Quadra 800.
>>
>> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>> ---
>> hw/m68k/q800.c | 9 +++++++++
>> 1 file changed, 9 insertions(+)

>> +/*
>> + * Slot 0x9 is reserved for use by the in-built framebuffer whilst only
>> + * slots 0xc, 0xd and 0xe physically exist on the Quadra 800
>> + */
>> +#define Q800_NUBUS_SLOTS_AVAILABLE    ((1UL << 0x9) | (1UL << 0xc) | \
>> +                                       (1UL << 0xd) | (1UL << 0xe))
> 
> There is a BIT(x) macro for these kind of constants that I find more
> readable as there would be less < signs and perenthesis but I don't
> insist on using it just note for consideration in case you need another
> respin for other reasons. (That macro could also be used to shorten the
> ~(1UL << nr_bits)
> values in other patches.)

Good idea.