Re: [PATCH] gitlab-ci: Mark manual-only jobs as allow_failure

[Thomas Huth]

On 15/09/2021 14.34, Peter Maydell wrote:
> If a gitlab CI job is marked as manual-only but is not marked
> as allow_failure, then gitlab considers that the pipeline is
> "blocked" until the job has been manually triggered. We need
> to mark these manual-only jobs as also allow_failure: true
> so that gitlab doesn't insist that they have run before it
> will consider the pipeline to be complete.
>
> Fixes: 4c9af1ea1457782cf0adb29
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   .gitlab-ci.d/custom-runners.yml | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
>
> diff --git a/.gitlab-ci.d/custom-runners.yml b/.gitlab-ci.d/custom-runners.yml
> index bcd22ca293c..a89a20da48d 100644
> --- a/.gitlab-ci.d/custom-runners.yml
> +++ b/.gitlab-ci.d/custom-runners.yml
> @@ -60,8 +60,10 @@ ubuntu-18.04-s390x-alldbg:
>    rules:
>    - if: '$CI_PROJECT_NAMESPACE == "qemu-project" && $CI_COMMIT_BRANCH =~ 
> /^staging/'
>      when: manual
> +   allow_failure: true
>    - if: "$S390X_RUNNER_AVAILABLE"
>      when: manual
> +   allow_failure: true
>    script:
>    - mkdir build
>    - cd build
Do we need the "allow_failure: true" on both parts, for the staging branch 
and for the manual rule? Or would it be enough for the manual rule? Anyway:

Acked-by: Thomas Huth <thuth@redhat.com>