[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v11 05/10] arm/hvf: Add a WFI handler
From: |
Peter Maydell |
Subject: |
Re: [PATCH v11 05/10] arm/hvf: Add a WFI handler |
Date: |
Thu, 16 Sep 2021 13:18:18 +0100 |
On Wed, 15 Sept 2021 at 19:10, Alexander Graf <agraf@csgraf.de> wrote:
>
> From: Peter Collingbourne <pcc@google.com>
>
> Sleep on WFI until the VTIMER is due but allow ourselves to be woken
> up on IPI.
>
> In this implementation IPI is blocked on the CPU thread at startup and
> pselect() is used to atomically unblock the signal and begin sleeping.
> The signal is sent unconditionally so there's no need to worry about
> races between actually sleeping and the "we think we're sleeping"
> state. It may lead to an extra wakeup but that's better than missing
> it entirely.
>
> Signed-off-by: Peter Collingbourne <pcc@google.com>
> [agraf: Remove unused 'set' variable, always advance PC on WFX trap,
> support vm stop / continue operations and cntv offsets]
> Signed-off-by: Alexander Graf <agraf@csgraf.de>
> Acked-by: Roman Bolshakov <r.bolshakov@yadro.com>
> Reviewed-by: Sergio Lopez <slp@redhat.com>
>
> ---
Other than the points Philippe raises,
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- Re: [PATCH v11 01/10] arm: Move PMC register definitions to cpu.h, (continued)
- [PATCH v11 05/10] arm/hvf: Add a WFI handler, Alexander Graf, 2021/09/15
- [PATCH v11 06/10] hvf: arm: Implement -cpu host, Alexander Graf, 2021/09/15
- Re: [PATCH v11 06/10] hvf: arm: Implement -cpu host, Peter Maydell, 2021/09/16
- Re: [PATCH v11 06/10] hvf: arm: Implement -cpu host, Alexander Graf, 2021/09/16
- Re: [PATCH v11 06/10] hvf: arm: Implement -cpu host, Peter Maydell, 2021/09/16
- Re: [PATCH v11 06/10] hvf: arm: Implement -cpu host, Ard Biesheuvel, 2021/09/16
- Re: [PATCH v11 06/10] hvf: arm: Implement -cpu host, Peter Maydell, 2021/09/16
- Re: [PATCH v11 06/10] hvf: arm: Implement -cpu host, Ard Biesheuvel, 2021/09/22
- Re: [PATCH v11 06/10] hvf: arm: Implement -cpu host, Peter Maydell, 2021/09/22
- Re: [PATCH v11 06/10] hvf: arm: Implement -cpu host, Ard Biesheuvel, 2021/09/22
- Re: [PATCH v11 06/10] hvf: arm: Implement -cpu host, Alexander Graf, 2021/09/16