Re: [PATCH v3 02/16] iotests/mirror-top-perms: Adjust imports

[Philippe Mathieu-Daudé]

On 9/16/21 4:27 PM, John Snow wrote:
> On Thu, Sep 16, 2021 at 12:27 AM Philippe Mathieu-Daudé
> <philmd@redhat.com <mailto:philmd@redhat.com>> wrote:
> 
>     On 9/16/21 6:09 AM, John Snow wrote:
>     > We need to import things from the qemu namespace; importing the
>     > namespace alone doesn't bring the submodules with it -- unless someone
>     > else (like iotests.py) imports them too.
>     >
>     > Adjust the imports.
>     >
>     > Signed-off-by: John Snow <jsnow@redhat.com <mailto:jsnow@redhat.com>>
>     > ---
>     >  tests/qemu-iotests/tests/mirror-top-perms | 7 ++++---
>     >  1 file changed, 4 insertions(+), 3 deletions(-)
>     >
>     > diff --git a/tests/qemu-iotests/tests/mirror-top-perms
>     b/tests/qemu-iotests/tests/mirror-top-perms
>     > index 2fc8dd66e0..de18182590 100755
>     > --- a/tests/qemu-iotests/tests/mirror-top-perms
>     > +++ b/tests/qemu-iotests/tests/mirror-top-perms
>     > @@ -25,7 +25,8 @@ from iotests import qemu_img
>     > 
>     >  # Import qemu after iotests.py has amended sys.path
>     >  # pylint: disable=wrong-import-order
>     > -import qemu
>     > +from qemu import qmp
>     > +from qemu.machine import machine
> 
>     Not straight-forward import name...
> 
> 
> You mean the 'qemu.machine.machine' path? If so, I agree. It will be
> fixed when I refactor QEMUMachine. A/QMP happens first.

Good news!