[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RFC 02/13] hw/nvme: move zns helpers and types into zoned.h
|
From: |
Keith Busch |
|
Subject: |
Re: [PATCH RFC 02/13] hw/nvme: move zns helpers and types into zoned.h |
|
Date: |
Thu, 16 Sep 2021 09:06:05 -0700 |
On Tue, Sep 14, 2021 at 10:37:26PM +0200, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> Move ZNS related helpers and types into zoned.h. Use a common prefix
> (nvme_zoned or nvme_ns_zoned) for zns related functions.
Just a nitpicks on the naming, you can feel free to ignore.
Since we're within NVMe specific protocol here, using that terminology
should be fine. I prefer "nvme_zns_" for the prefix.
And for function names like "nvme_zoned_zs()", the "zs" abbreviation
expands to "zone_state", so "zone" is redunant. I think
"nvme_zns_state()" is a good name for that one.
- [PATCH RFC 00/13] hw/nvme: experimental user-creatable objects, Klaus Jensen, 2021/09/14
- [PATCH RFC 02/13] hw/nvme: move zns helpers and types into zoned.h, Klaus Jensen, 2021/09/14
- Re: [PATCH RFC 02/13] hw/nvme: move zns helpers and types into zoned.h,
Keith Busch <=
- [PATCH RFC 03/13] hw/nvme: move zoned namespace members to separate struct, Klaus Jensen, 2021/09/14
- [PATCH RFC 01/13] hw/nvme: move dif/pi prototypes into dif.h, Klaus Jensen, 2021/09/14
- [PATCH RFC 04/13] hw/nvme: move nvm namespace members to separate struct, Klaus Jensen, 2021/09/14
- [PATCH RFC 08/13] hw/nvme: hoist qdev state from controller, Klaus Jensen, 2021/09/14
- [PATCH RFC 06/13] nvme: add structured type for nguid, Klaus Jensen, 2021/09/14
- [PATCH RFC 05/13] hw/nvme: move BlockBackend to NvmeNamespaceNvm, Klaus Jensen, 2021/09/14
- [PATCH RFC 07/13] hw/nvme: hoist qdev state from namespace, Klaus Jensen, 2021/09/14
- [PATCH RFC 09/13] hw/nvme: add experimental device x-nvme-ctrl, Klaus Jensen, 2021/09/14
- [PATCH RFC 11/13] hw/nvme: add experimental abstract object x-nvme-ns, Klaus Jensen, 2021/09/14