RE: [PATCH v3] target/ppc: Fix 64-bit decrementer

[Luis Fernando Fujita Pires]

From: Cédric Le Goater <clg@kaod.org>
> >> +    target_long signed_value;
> >> +    target_long signed_decr;
> >
> > Since these values will be the results of sextract64, it's probably better 
> > to
> define them as int64_t.
> 
> but then it breaks the code doing the logging on PPC32 targets :/

You mean here?
> >>       LOG_TB("%s: " TARGET_FMT_lx " => " TARGET_FMT_lx "\n", __func__,
> >> -                decr, value);
> >> +                decr, signed_value);
> >
> > While this reproduces the behavior we previously had, I think it would be 
> > more
> consistent if we logged what we had before the sign-extension ('value' instead
> of 'signed_value'). And 'decr' is okay, which is also not sign-extended.

It won't break if you log 'value' instead of 'signed_value', right?

> > The diff < 0 case:
> >          decr = -muldiv64(-diff, tb_env->decr_freq,
> > NANOSECONDS_PER_SECOND); should probably just be:
> >          decr = -1;
> > to comply with the minimum possible values specified by the ISA.
> > But, again, this doesn't impact your patch directly.
> 
> We can try to address that in a followup patch.

Agreed.

Thanks!

--
Luis Pires
Instituto de Pesquisas ELDORADO
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>