qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 09/41] linux-user/host/alpha: Populate host_signal.h


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 09/41] linux-user/host/alpha: Populate host_signal.h
Date: Sun, 19 Sep 2021 20:11:47 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0

On 9/19/21 20:07, Richard Henderson wrote:
> On 9/19/21 11:03 AM, Philippe Mathieu-Daudé wrote:
>> On 9/18/21 20:44, Richard Henderson wrote:
>>> Split host_signal_pc and host_signal_write out of user-exec.c.
>>>
>>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>>> ---
>>>   linux-user/host/alpha/host-signal.h | 41 +++++++++++++++++++++++++++++
>>>   accel/tcg/user-exec.c               | 31 +---------------------
>>>   2 files changed, 42 insertions(+), 30 deletions(-)
>>>   create mode 100644 linux-user/host/alpha/host-signal.h
>>
>> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>
> 
> Amusingly, this is one bit that we might want to simply drop.  The
> remaining required entries in linux-user/host/arch/ are missing, so one
> can't actually build with alpha host at the moment.
> 
> Similarly, linux-user/host/ia64/ is also unusable, because we would have
> hit the #error in accel/tcg/user-exec.c, missing the host signal handling.

Understandable. Since part of the work is done, I'd rather keep the
patches in this series and drop them after in another series (easier
to revert for someone interested in fixing these targets).



reply via email to

[Prev in Thread] Current Thread [Next in Thread]