Re: [RFC PATCH] tests/acpi/pcihp: add unit tests for hotplug on multifunction bridges for q35

[Ani Sinha]

On Mon, 20 Sep 2021, Igor Mammedov wrote:


> > > > > diff --git a/tests/qtest/bios-tables-test.c 
> > > > > b/tests/qtest/bios-tables-test.c
> > > > > index 51d3a4e239..c92b70e8b8 100644
> > > > > --- a/tests/qtest/bios-tables-test.c
> > > > > +++ b/tests/qtest/bios-tables-test.c
> > > > > @@ -859,6 +859,33 @@ static void test_acpi_q35_tcg_bridge(void)
> > > > >      free_test_data(&data);
> > > > >  }
> > > > >
> > > > > +static void test_acpi_q35_multif_bridge(void)
> > > > > +{
> > > > > +    test_data data = {
> > > > > +        .machine = MACHINE_Q35,
> > > > > +        .variant = ".multi-bridge",
> > > >
> > > > > +        .required_struct_types = base_required_struct_types,
> > > > > +        .required_struct_types_len = 
> > > > > ARRAY_SIZE(base_required_struct_types)
> > > > do we care, i.e. why is this here?
> > >
> > > This verifies the smbios struct. It seems most of the other tests uses it.
> > > So I left it in this test also.
> > > Which of the tests should not be testing smbios?
> >
> > Right now smbios is only tested for non-uefi firmware. There are lots
> > of tests that does not use uefi yet exercize the smbios struct tests.
> > For example:
> >
> > test_acpi_piix4_tcg
> > test_acpi_piix4_tcg_bridge
> > test_acpi_piix4_no_root_hotplug
> > test_acpi_piix4_no_bridge_hotplug
> > test_acpi_piix4_no_acpi_pci_hotplug
> > test_acpi_q35_tcg
> > test_acpi_q35_tcg_bridge
> > test_acpi_q35_tcg_mmio64
> > test_acpi_q35_tcg_ipmi
> > test_acpi_piix4_tcg_ipmi
> >
> > Should the smbios struct verification tests be removed from all of them?
>
> I'd leave them alone, and just remove smbios testing from this patch.
>

I have sent a v3. Please ignore v2.