Re: [PATCH v12 06/10] hvf: arm: Implement -cpu host

[Peter Maydell]

On Thu, 16 Sept 2021 at 17:08, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> On 9/16/21 5:54 PM, Alexander Graf wrote:
> > Now that we have working system register sync, we push more target CPU
> > properties into the virtual machine. That might be useful in some
> > situations, but is not the typical case that users want.
> >
> > So let's add a -cpu host option that allows them to explicitly pass all
> > CPU capabilities of their host CPU into the guest.
> >
> > Signed-off-by: Alexander Graf <agraf@csgraf.de>
> > Acked-by: Roman Bolshakov <r.bolshakov@yadro.com>
> > Reviewed-by: Sergio Lopez <slp@redhat.com>
> > Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> >
> > ---
>
> > diff --git a/target/arm/hvf_arm.h b/target/arm/hvf_arm.h
> > new file mode 100644
> > index 0000000000..603074a331
> > --- /dev/null
> > +++ b/target/arm/hvf_arm.h
> > @@ -0,0 +1,19 @@
> > +/*
> > + * QEMU Hypervisor.framework (HVF) support -- ARM specifics
> > + *
> > + * Copyright (c) 2021 Alexander Graf
> > + *
> > + * This work is licensed under the terms of the GNU GPL, version 2 or 
> > later.
> > + * See the COPYING file in the top-level directory.
> > + *
> > + */
> > +
> > +#ifndef QEMU_HVF_ARM_H
> > +#define QEMU_HVF_ARM_H
> > +
> > +#include "qemu/accel.h"
>
> This include shouldn't be necessary.

Yep, and we don't need to add it to any .c files, they all seem to
compile OK (on osx and Linux) without explicitly including this
anywhere. Since this is the only change needed to an otherwise
fully-reviewed patchset I'll just fold this change in locally.

-- PMM