qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 12/30] tcg/loongarch: Implement not/and/or/xor/nor/andc/orc o


From: Richard Henderson
Subject: Re: [PATCH 12/30] tcg/loongarch: Implement not/and/or/xor/nor/andc/orc ops
Date: Mon, 20 Sep 2021 07:54:47 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 9/20/21 1:04 AM, WANG Xuerui wrote:
+    case INDEX_op_andc_i32:
+    case INDEX_op_andc_i64:
+        tcg_out_opc_andn(s, a0, a1, a2);
+        break;

You may want to add the constant case here, implemented with andi, with the constant inverted, similarly to the negation of the N constraint. We do not (but probably should) canonicalize andc/orc/eqv constants to and/or/xor during optimization...

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]