[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 01/11] configure: don't override the selected host test co
From: |
Alex Bennée |
Subject: |
Re: [PATCH v1 01/11] configure: don't override the selected host test compiler if defined |
Date: |
Mon, 20 Sep 2021 17:37:19 +0100 |
User-agent: |
mu4e 1.7.0; emacs 28.0.50 |
Ed Maste <emaste@freebsd.org> writes:
> On Fri, 17 Sept 2021 at 12:27, Alex Bennée <alex.bennee@linaro.org> wrote:
>>
>> There are not many cases you would want to do this but one is if you
>> want to use a test friendly compiler like gcc instead of a system
>> compiler like clang. Either way we should honour the users choice if
>> they have made it.
>
> A little bit of a tangent, but I'm curious about this comment - what
> aspects of GCC make it more test friendly? (I help maintain LLVM tools
> on FreeBSD, and would like to make sure they provide as good an
> experience as possible.)
Some of the inline assembler in the old tests trips up LLVM. There is a
chance the inline assembly is a bit bogus with it's constraints and GCC
is just a bit more lax and accepting.
I'm totally fine with merging something that restores support for clang
for building tests it just needs the appropriate fixups to the tests. We
already use clang for the hexagon builds after all. Once that is done we
can drop the stuff in cf22f936f2 (tests/tcg: don't allow clang as a
cross compiler).
--
Alex Bennée
- [PATCH v1 00/11] testing and plugin pre-PR (configure, gitlab, plugins), Alex Bennée, 2021/09/17
- [PATCH v1 01/11] configure: don't override the selected host test compiler if defined, Alex Bennée, 2021/09/17
- [PATCH v1 08/11] gitlab: skip the check-patch job on the upstream repo, Alex Bennée, 2021/09/17
- [PATCH v1 04/11] tests/docker: promote debian-riscv64-cross to a full image, Alex Bennée, 2021/09/17
- [PATCH v1 02/11] tests/tcg/sha1: remove endian include, Alex Bennée, 2021/09/17
- [PATCH v1 03/11] tests/tcg: move some multiarch files and make conditional, Alex Bennée, 2021/09/17
- [PATCH v1 05/11] gitlab: Add cross-riscv64-system, cross-riscv64-user, Alex Bennée, 2021/09/17
- [PATCH v1 06/11] python: Update for pylint 2.10, Alex Bennée, 2021/09/17