Re: [PATCH 2/3] scsi: make io_timeout configurable

[Hannes Reinecke]

On 9/20/21 8:56 PM, Paolo Bonzini wrote:
> On Mon, Nov 16, 2020 at 7:31 PM Hannes Reinecke <hare@suse.de> wrote:
> > The current code sets an infinite timeout on SG_IO requests,
> > causing the guest to stall if the host experiences a frame
> > loss.
> > This patch adds an 'io_timeout' parameter for SCSIDevice to
> > make the SG_IO timeout configurable, and also shortens the
> > default timeout to 30 seconds to avoid infinite stalls.
>
> Hannes, could 30 seconds be a bit too short for tape drives?
It would, but then anyone attempting to use tapes via qemu emulation 
deserves to suffer.
Tapes are bitchy even when used normally, so attempting to use them 
under qemu emulation will land you with lots of unhappy experiences, 
where the timeout is the least of your problems.
I sincerely doubt anyone will be using tapes here.
Not in real-world scenarios.

Cheers,

Hannes
--
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer