qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/5] target/arm: Move gdbstub related code out of helper.c


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 3/5] target/arm: Move gdbstub related code out of helper.c
Date: Tue, 21 Sep 2021 20:10:39 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0

On 9/21/21 18:28, Peter Maydell wrote:
Currently helper.c includes some code which is part of the arm
target's gdbstub support.  This code has a better home: in gdbstub.c
and gdbstub64.c.  Move it there.

Because aarch64_fpu_gdb_get_reg() and aarch64_fpu_gdb_set_reg() move
into gdbstub64.c, this means that they're now compiled only for
TARGET_AARCH64 rather than always.  That is the only case when they
would ever be used, but it does mean that the ifdef in
arm_cpu_register_gdb_regs_for_features() needs to be adjusted to
match.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
  target/arm/internals.h |   7 ++
  target/arm/gdbstub.c   | 130 ++++++++++++++++++++
  target/arm/gdbstub64.c | 140 +++++++++++++++++++++
  target/arm/helper.c    | 271 -----------------------------------------
  4 files changed, 277 insertions(+), 271 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]