Re: [PATCH v2 20/30] tcg/loongarch64: Implement setcond ops

[Richard Henderson]

On 9/21/21 1:19 PM, WANG Xuerui wrote:
> +static void tcg_out_setcond(TCGContext *s, TCGCond cond, TCGReg ret,
> +                            TCGReg arg1, TCGReg arg2, bool c1, bool c2)
> +{
> +    TCGReg tmp;
> +
> +    if (c1) {
> +        tcg_debug_assert(arg1 == 0);
> +    }
> +    if (c2) {
> +        tcg_debug_assert(arg2 == 0);
> +    }

You don't need to work quite this hard.  Only the second argument will be constant.  If 
both are constant, we will have folded the operation away.  If the first argument was 
constant, we will swap the condition.

> +    switch (cond) {
> +    case TCG_COND_EQ:
> +        if (c1) {
> +            tmp = arg2;
> +        } else if (c2) {
> +            tmp = arg1;
> +        } else {
> +            tcg_out_opc_sub_d(s, ret, arg1, arg2);

    if (!c2) {
        ...
    }

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~