qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 16/16] iotests/linters: check mypy files all at once


From: John Snow
Subject: Re: [PATCH v3 16/16] iotests/linters: check mypy files all at once
Date: Wed, 22 Sep 2021 16:41:07 -0400



On Fri, Sep 17, 2021 at 7:23 AM Hanna Reitz <hreitz@redhat.com> wrote:
On 16.09.21 06:09, John Snow wrote:
> We can circumvent the '__main__' redefinition problem by passing
> --scripts-are-modules. Take mypy out of the loop per-filename and check
> everything in one go: it's quite a bit faster.

Is it possible to pull this to the beginning of the series?  Just
because patch 14 has to make everything quite slow (which might be a
tiny nuisance in bisecting some day?).


Reasonable. Yes.
 
--js

>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>   tests/qemu-iotests/linters.py | 62 ++++++++++++++++-------------------
>   1 file changed, 29 insertions(+), 33 deletions(-)

Reviewed-by: Hanna Reitz <hreitz@redhat.com>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]