Re: [PATCH] docs/nvdimm: Update nvdimm option value in machine example

[Laurent Vivier]

Le 23/09/2021 à 11:47, Pankaj Gupta a écrit :
> ping

Could you post your patch with an email address ("From") that is the same as 
the "Signed-off-by"?

https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line

Thanks,
Laurent

>> Update nvdimm option value in example command from "-machine pc,nvdimm"
>> to "-machine pc,nvdimm=on" as former complains with the below error:
>>
>> "qemu-system-x86_64: -machine pc,nvdimm: Expected '=' after parameter 
>> 'nvdimm'"
>>
>> Signed-off-by: Pankaj Gupta <pankaj.gupta@ionos.com>
>> ---
>>  docs/nvdimm.txt | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/docs/nvdimm.txt b/docs/nvdimm.txt
>> index 0aae682be3..fd7773dc5a 100644
>> --- a/docs/nvdimm.txt
>> +++ b/docs/nvdimm.txt
>> @@ -15,7 +15,7 @@ backend (i.e. memory-backend-file and memory-backend-ram). 
>> A simple
>>  way to create a vNVDIMM device at startup time is done via the
>>  following command line options:
>>
>> - -machine pc,nvdimm
>> + -machine pc,nvdimm=on
>>   -m $RAM_SIZE,slots=$N,maxmem=$MAX_SIZE
>>   -object 
>> memory-backend-file,id=mem1,share=on,mem-path=$PATH,size=$NVDIMM_SIZE,readonly=off
>>   -device nvdimm,id=nvdimm1,memdev=mem1,unarmed=off
>> --
>> 2.25.1
>>
>