Re: [PATCH v5 04/20] nubus: use bitmap to manage available slots

[Laurent Vivier]

Le 23/09/2021 à 11:12, Mark Cave-Ayland a écrit :
> Convert nubus_device_realize() to use a bitmap to manage available slots to 
> allow
> for future Nubus devices to be plugged into arbitrary slots from the command 
> line
> using a new qdev "slot" parameter for nubus devices.
> 
> Update mac_nubus_bridge_init() to only allow slots 0x9 to 0xe on a Macintosh
> machines as documented in "Desigining Cards and Drivers for the Macintosh 
> Family".
> 
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
>  hw/nubus/mac-nubus-bridge.c         |  4 ++++
>  hw/nubus/nubus-bus.c                |  5 +++--
>  hw/nubus/nubus-device.c             | 32 +++++++++++++++++++++++------
>  include/hw/nubus/mac-nubus-bridge.h |  4 ++++
>  include/hw/nubus/nubus.h            | 13 ++++++------
>  5 files changed, 43 insertions(+), 15 deletions(-)
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>