Re: [RFC PATCH v2 02/16] qapi: Implement query-machine-phase QMP command

[Damien Hedde]

On 9/22/21 19:37, Philippe Mathieu-Daudé wrote:
> On 9/22/21 18:13, Damien Hedde wrote:
> > From: Mirela Grujic <mirela.grujic@greensocs.com>
> >
> > The command returns current machine initialization phase.
> >  From now on, the MachineInitPhase enum is generated from the
> > QAPI schema.
> >
> > Signed-off-by: Mirela Grujic <mirela.grujic@greensocs.com>
>
> Missing your S-o-b, otherwise:

Sorry. I did not realize I had to add it since it was already done by 
Mirela. I'll add it for this patch and patches 1, 6 and 8.

> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com >
> > ---
> >   qapi/machine.json          | 56 ++++++++++++++++++++++++++++++++++++++
> >   include/hw/qdev-core.h     | 30 ++------------------
> >   hw/core/machine-qmp-cmds.c |  9 ++++++
> >   hw/core/qdev.c             |  5 ++++
> >   4 files changed, 72 insertions(+), 28 deletions(-)