Re: [PATCH v5 14/20] mac-nubus-bridge: rename MacNubusState to MacNubusBridge

[Laurent Vivier]

Le 23/09/2021 à 14:50, Mark Cave-Ayland a écrit :
> On 23/09/2021 11:35, Laurent Vivier wrote:
> 
>> Le 23/09/2021 à 11:13, Mark Cave-Ayland a écrit :
>>> This better reflects that the mac-nubus-bridge device is derived from the
>>> nubus-bridge device, and that the structure represents the state of the 
>>> bridge
>>> device and not the Nubus itself. Also update the comment in the file header 
>>> to
>>> reflect that mac-nubus-bridge is specific to the Macintosh.
>>>
>>> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>>> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> ---
>>>   hw/nubus/mac-nubus-bridge.c         | 8 +++++---
>>>   include/hw/nubus/mac-nubus-bridge.h | 4 ++--
>>>   2 files changed, 7 insertions(+), 5 deletions(-)
>>>
>>
>>
>> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
>>
>> (it could be merged with previous one)
> 
> I like to try and keep renames on a per-device basis if possible, even if 
> it's just to help rebasing
> during development.

Ok. No problem.

> Other than that, is there anything else outstanding you think would require a 
> v6 series?

Except if you want to address comments from Philippe, I can collect this series 
and send a PR.

Thanks,
Laurent