[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] hw/nvme: Return error for fused operations
From: |
Klaus Jensen |
Subject: |
Re: [PATCH v2] hw/nvme: Return error for fused operations |
Date: |
Thu, 23 Sep 2021 22:26:32 +0200 |
On Sep 15 17:43, Pankaj Raghav wrote:
> Currently, FUSED operations are not supported by QEMU. As per the 1.4 SPEC,
> controller should abort the command that requested a fused operation with
> an INVALID FIELD error code if they are not supported.
>
> Changes from v1:
> Added FUSE flag check also to the admin cmd processing as the FUSED
> operations are mentioned in the general SQE section in the SPEC.
>
> Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
> ---
> hw/nvme/ctrl.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
> index dc0e7b0030..2f247a9275 100644
> --- a/hw/nvme/ctrl.c
> +++ b/hw/nvme/ctrl.c
> @@ -3893,6 +3893,10 @@ static uint16_t nvme_io_cmd(NvmeCtrl *n, NvmeRequest
> *req)
> return ns->status;
> }
>
> + if (NVME_CMD_FLAGS_FUSE(req->cmd.flags)) {
> + return NVME_INVALID_FIELD;
> + }
> +
> req->ns = ns;
>
> switch (req->cmd.opcode) {
> @@ -5475,6 +5479,10 @@ static uint16_t nvme_admin_cmd(NvmeCtrl *n,
> NvmeRequest *req)
> return NVME_INVALID_FIELD | NVME_DNR;
> }
>
> + if (NVME_CMD_FLAGS_FUSE(req->cmd.flags)) {
> + return NVME_INVALID_FIELD;
> + }
> +
> switch (req->cmd.opcode) {
> case NVME_ADM_CMD_DELETE_SQ:
> return nvme_del_sq(n, req);
> --
> 2.25.1
Applied to nvme-next. Thanks!
signature.asc
Description: PGP signature