Re: [PATCH v2 6/9] bsd-user/mmap.c: line wrap change

[Richard Henderson]

On 9/21/21 9:56 PM, Warner Losh wrote:
> Keep the shifted expression on one line. It's the same number of lines
> and easier to read like this.
>
> Signed-off-by: Warner Losh <imp@bsdimp.com>
> ---
>   bsd-user/mmap.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/bsd-user/mmap.c b/bsd-user/mmap.c
> index bafbdacd31..8b763fffc3 100644
> --- a/bsd-user/mmap.c
> +++ b/bsd-user/mmap.c
> @@ -399,8 +399,8 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, int 
> prot,
>                  prot & PROT_WRITE ? 'w' : '-',
>                  prot & PROT_EXEC ? 'x' : '-');
>           if (flags & MAP_ALIGNMENT_MASK) {
> -            printf("MAP_ALIGNED(%u) ", (flags & MAP_ALIGNMENT_MASK)
> -                    >> MAP_ALIGNMENT_SHIFT);
> +            printf("MAP_ALIGNED(%u) ",
> +                   (flags & MAP_ALIGNMENT_MASK) >> MAP_ALIGNMENT_SHIFT);
>           }
>           if (flags & MAP_GUARD) {
>               printf("MAP_GUARD ");

I suppose.

If you're touching these lines at all it might be better to convert them all to qemu_log, 
protected by CPU_LOG_PAGE.  Then you can drop the ifdefs as well.


r~