Re: [PATCH v2 2/3] target/riscv: Implement the stval/mtval illegal instr

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/3] target/riscv: Implement the stval/mtval illegal instr

From:	Richard Henderson
Subject:	Re: [PATCH v2 2/3] target/riscv: Implement the stval/mtval illegal instruction
Date:	Fri, 24 Sep 2021 08:57:21 -0400
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 9/24/21 2:48 AM, Alistair Francis wrote:

But... more specific to this case.  Prior to this, was the exception handler 
allowed to
assume anything about the contents of stval?  Should the value have been zero?  
Would it
be wrong to write to stval unconditionally?  How does the guest OS know that it 
can rely
on stval being set?


As we didn't support writing the illegal instruction stval should be
zero before this patch.


Ok, that didn't quite answer the question...

If *wasn't* zero before this patch: we didn't write anything at all, and so keep whateverprevious value the previous exception wrote.

Is that a bug that needs fixing? Because you're still not writing anything to stval if!MTVAL_INST...

I simply wonder whether it's worthwhile to add the feature and feature test.


Do you just mean have it enabled all the time?


Yes, if without this feature the value of stval was undefined.


r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v2 0/3] RISC-V: Populate mtval and stval, Alistair Francis, 2021/09/08
- [PATCH v2 1/3] target/riscv: Set the opcode in DisasContext, Alistair Francis, 2021/09/08
  - Re: [PATCH v2 1/3] target/riscv: Set the opcode in DisasContext, Bin Meng, 2021/09/08
  - Re: [PATCH v2 1/3] target/riscv: Set the opcode in DisasContext, Richard Henderson, 2021/09/08
- [PATCH v2 2/3] target/riscv: Implement the stval/mtval illegal instruction, Alistair Francis, 2021/09/08
  - Re: [PATCH v2 2/3] target/riscv: Implement the stval/mtval illegal instruction, Bin Meng, 2021/09/08
  - Re: [PATCH v2 2/3] target/riscv: Implement the stval/mtval illegal instruction, Richard Henderson, 2021/09/08
    - Re: [PATCH v2 2/3] target/riscv: Implement the stval/mtval illegal instruction, Alistair Francis, 2021/09/24
    - Re: [PATCH v2 2/3] target/riscv: Implement the stval/mtval illegal instruction, Richard Henderson <=
    - Re: [PATCH v2 2/3] target/riscv: Implement the stval/mtval illegal instruction, Alistair Francis, 2021/09/28
- [PATCH v2 3/3] target/riscv: Set mtval and stval support, Alistair Francis, 2021/09/08
  - Re: [PATCH v2 3/3] target/riscv: Set mtval and stval support, Bin Meng, 2021/09/08

Prev by Date: Re: [PATCH v6 37/40] target/tricore: Restrict has_work() handler to sysemu
Next by Date: Re: [PATCH 01/11] qom: Reduce use of error_propagate()
Previous by thread: Re: [PATCH v2 2/3] target/riscv: Implement the stval/mtval illegal instruction
Next by thread: Re: [PATCH v2 2/3] target/riscv: Implement the stval/mtval illegal instruction
Index(es):
- Date
- Thread