Re: [PATCH v7 12/40] accel/qtest: Implement AccelOpsClass::has_work()

[Richard Henderson]

On 9/25/21 11:27 AM, Philippe Mathieu-Daudé wrote:
> > +static bool qtest_cpu_has_work(CPUState *cpu)
> > +{
> > +    g_assert_not_reached();
> > +}
>
> Sigh, this triggers:
>
> Running test qtest-i386/cpu-plug-test
> **
> ERROR:../accel/qtest/qtest.c:52:qtest_cpu_has_work: code should not be reached
> ERROR qtest-i386/cpu-plug-test - Bail out! 
> ERROR:../accel/qtest/qtest.c:52:qtest_cpu_has_work: code should not be reached
> Broken pipe

Ha ha, yes.  You beat me to the reply within minutes.

> I suppose it is in my interest to 'return false' here and call it
> a day...

I *think* that's the right thing, but I could see maybe "true" also makes sense.  I'll try 
and have a closer look.


r~