qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 04/30] tcg/loongarch64: Add generated instruction opcodes


From: WANG Xuerui
Subject: Re: [PATCH v5 04/30] tcg/loongarch64: Add generated instruction opcodes and encoding helpers
Date: Sun, 26 Sep 2021 00:19:05 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101 Thunderbird/94.0a1

Hi Richard,

On 9/25/21 22:20, Richard Henderson wrote:
On 9/24/21 11:51 PM, WANG Xuerui wrote:
Hi all,

On 9/25/21 01:25, WANG Xuerui wrote:
Signed-off-by: WANG Xuerui <git@xen0n.name>
Acked-by: Richard Henderson <richard.henderson@linaro.org>
---
  tcg/loongarch64/tcg-insn-defs.c.inc | 979 ++++++++++++++++++++++++++++
  1 file changed, 979 insertions(+)
  create mode 100644 tcg/loongarch64/tcg-insn-defs.c.inc
This patch series is only lacking Reviewed-by tag for this commit now; may I ask whose review do I additionally need to get this across the finish line? Or is this series waiting for upstream merge of toolchain and kernel support too?

An ack is as good as a review in this case.
I don't normally "review" machine-generated code.

While the toolchain is not upstream, the ABI seems solid enough. So there's no worries on that account.  The safe-syscall code has nothing in it that's kernel api specific, so there's no block there either.

It looks like one more revision to address the valid nits in tcg_out_movi are all that remains before I can merge this.  I'll work around the conflict with my SIGSEGV patch set, and Cc you for testing when it is time.
Thanks for the clarification; v6 is ready and I'll send shortly. (And sorry for the conflict! I looked at the refactor series, though, and it seems some simple code motion is enough. LoongArch is not that different from other arches after all...)


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]