[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 04/26] qom: Add memory-backend-epc ObjectOptions support
From: |
Yang Zhong |
Subject: |
Re: [PATCH v5 04/26] qom: Add memory-backend-epc ObjectOptions support |
Date: |
Mon, 27 Sep 2021 13:20:34 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Sep 24, 2021 at 08:56:40AM -0500, Eric Blake wrote:
> On Fri, Sep 24, 2021 at 01:24:47PM +0200, Paolo Bonzini wrote:
> > From: Yang Zhong <yang.zhong@intel.com>
> >
> > Add the new 'memory-backend-epc' user creatable QOM object in
> > the ObjectOptions to support SGX since v6.1, or the sgx backend
> > object cannot bootup.
> >
> > Signed-off-by: Yang Zhong <yang.zhong@intel.com>
> > Message-Id: <20210719112136.57018-4-yang.zhong@intel.com>
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> > qapi/qom.json | 19 +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> >
> > diff --git a/qapi/qom.json b/qapi/qom.json
> > index a25616bc7a..0222bb4506 100644
> > --- a/qapi/qom.json
> > +++ b/qapi/qom.json
> > @@ -647,6 +647,23 @@
> > '*hugetlbsize': 'size',
> > '*seal': 'bool' } }
> >
> > +##
> > +# @MemoryBackendEpcProperties:
> > +#
> > +# Properties for memory-backend-epc objects.
> > +#
> > +# The @share boolean option is true by default with epc
> > +#
> > +# The @merge boolean option is false by default with epc
> > +#
> > +# The @dump boolean option is false by default with epc
> > +#
> > +# Since: 6.2
> > +##
> > +{ 'struct': 'MemoryBackendEpcProperties',
> > + 'base': 'MemoryBackendProperties',
> > + 'data': {} }
>
> Is the intent to add more members to data in later patches? Otherwise,...
No new members will be added. thanks! MemoryBackendProperties will replace
this.
Yang
>
> > +
> > ##
> > # @PrManagerHelperProperties:
> > #
> > @@ -797,6 +814,7 @@
> > { 'name': 'memory-backend-memfd',
> > 'if': 'CONFIG_LINUX' },
> > 'memory-backend-ram',
> > + 'memory-backend-epc',
> > 'pef-guest',
> > 'pr-manager-helper',
> > 'qtest',
> > @@ -855,6 +873,7 @@
> > 'memory-backend-memfd': { 'type':
> > 'MemoryBackendMemfdProperties',
> > 'if': 'CONFIG_LINUX' },
> > 'memory-backend-ram': 'MemoryBackendProperties',
> > + 'memory-backend-epc': 'MemoryBackendEpcProperties',
>
> ...this could have just been MemoryBackendProperties.
Ditto, thanks!
Yang
>
> > 'pr-manager-helper': 'PrManagerHelperProperties',
> > 'qtest': 'QtestProperties',
> > 'rng-builtin': 'RngProperties',
> > --
> > 2.31.1
> >
> >
>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3266
> Virtualization: qemu.org | libvirt.org
- [PATCH v5 00/26] Qemu SGX virtualization, Paolo Bonzini, 2021/09/24
- [PATCH v5 01/26] memory: Add RAM_PROTECTED flag to skip IOMMU mappings, Paolo Bonzini, 2021/09/24
- [PATCH v5 06/26] vl: Add sgx compound properties to expose SGX EPC sections to guest, Paolo Bonzini, 2021/09/24
- [PATCH v5 02/26] Kconfig: Add CONFIG_SGX support, Paolo Bonzini, 2021/09/24
- [PATCH v5 04/26] qom: Add memory-backend-epc ObjectOptions support, Paolo Bonzini, 2021/09/24
- [PATCH v5 09/26] i386: Add SGX CPUID leaf FEAT_SGX_12_0_EBX, Paolo Bonzini, 2021/09/24
- [PATCH v5 10/26] i386: Add SGX CPUID leaf FEAT_SGX_12_1_EAX, Paolo Bonzini, 2021/09/24
- [PATCH v5 12/26] i386: Add feature control MSR dependency when SGX is enabled, Paolo Bonzini, 2021/09/24
- [PATCH v5 13/26] i386: Update SGX CPUID info according to hardware/KVM/user input, Paolo Bonzini, 2021/09/24
- [PATCH v5 15/26] i386: Propagate SGX CPUID sub-leafs to KVM, Paolo Bonzini, 2021/09/24
- [PATCH v5 05/26] i386: Add 'sgx-epc' device to expose EPC sections to guest, Paolo Bonzini, 2021/09/24
- [PATCH v5 16/26] Adjust min CPUID level to 0x12 when SGX is enabled, Paolo Bonzini, 2021/09/24
- [PATCH v5 18/26] hw/i386/pc: Account for SGX EPC sections when calculating device memory, Paolo Bonzini, 2021/09/24
- [PATCH v5 11/26] i386: Add get/set/migrate support for SGX_LEPUBKEYHASH MSRs, Paolo Bonzini, 2021/09/24
- [PATCH v5 03/26] hostmem: Add hostmem-epc as a backend for SGX EPC, Paolo Bonzini, 2021/09/24