[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] allwinner-h3: Switch to SMC as PSCI conduit
From: |
Peter Maydell |
Subject: |
Re: [PATCH] allwinner-h3: Switch to SMC as PSCI conduit |
Date: |
Mon, 27 Sep 2021 11:11:39 +0100 |
On Wed, 22 Sept 2021 at 20:41, Niek Linnenbank <nieklinnenbank@gmail.com> wrote:
>
> Hi Alexander,
>
> I've tested your patch on the acceptance tests and they all pass:
>
> ARMBIAN_ARTIFACTS_CACHED=yes AVOCADO_ALLOW_LARGE_STORAGE=yes avocado
> --show=app,console run -t machine:orangepi-pc
> tests/acceptance/boot_linux_console.py
> ...
> RESULTS : PASS 5 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 |
> CANCEL 0
> JOB TIME : 116.08 s
>
> Also the latest linux kernel is working OK with all cores booting up fine.
>
> At first I couldn't really figure out why simply changing the conduit there
> works, without also changing the Linux kernel to match.
> But it turns out we just override the provided DTB for this in
> fdt_add_psci_node() in hw/arm/boot.c and the Linux kernel then uses that to
> decide between HVC and SMC.
>
> So looks fine to me:
> Reviewed-by: Niek Linnenbank <nieklinnenbank@gmail.com>
> Tested-by: Niek Linnenbank <nieklinnenbank@gmail.com>
Applied to target-arm.next, thanks.
PS: if you put spaces in front of 'Reviewed-by' type tags, the automated
tooling doesn't recognize them.
-- PMM