[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 10/32] python/aqmp: add configurable read buffer limit
From: |
John Snow |
Subject: |
[PULL 10/32] python/aqmp: add configurable read buffer limit |
Date: |
Mon, 27 Sep 2021 15:24:51 -0400 |
QMP can transmit some pretty big messages, and the default limit of 64KB
isn't sufficient. Make sure that we can configure it.
Reported-by: G S Niteesh Babu <niteesh.gs@gmail.com>
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-id: 20210915162955.333025-11-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
---
python/qemu/aqmp/protocol.py | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/python/qemu/aqmp/protocol.py b/python/qemu/aqmp/protocol.py
index 62c26ede5a4..2ef19e96932 100644
--- a/python/qemu/aqmp/protocol.py
+++ b/python/qemu/aqmp/protocol.py
@@ -189,6 +189,9 @@ class AsyncProtocol(Generic[T]):
#: Logger object for debugging messages from this connection.
logger = logging.getLogger(__name__)
+ # Maximum allowable size of read buffer
+ _limit = (64 * 1024)
+
# -------------------------
# Section: Public interface
# -------------------------
@@ -452,6 +455,7 @@ async def _client_connected_cb(reader: asyncio.StreamReader,
port=address[1],
ssl=ssl,
backlog=1,
+ limit=self._limit,
)
else:
coro = asyncio.start_unix_server(
@@ -459,6 +463,7 @@ async def _client_connected_cb(reader: asyncio.StreamReader,
path=address,
ssl=ssl,
backlog=1,
+ limit=self._limit,
)
server = await coro # Starts listening
@@ -482,9 +487,18 @@ async def _do_connect(self, address: Union[str, Tuple[str,
int]],
self.logger.debug("Connecting to %s ...", address)
if isinstance(address, tuple):
- connect = asyncio.open_connection(address[0], address[1], ssl=ssl)
+ connect = asyncio.open_connection(
+ address[0],
+ address[1],
+ ssl=ssl,
+ limit=self._limit,
+ )
else:
- connect = asyncio.open_unix_connection(path=address, ssl=ssl)
+ connect = asyncio.open_unix_connection(
+ path=address,
+ ssl=ssl,
+ limit=self._limit,
+ )
self._reader, self._writer = await connect
self.logger.debug("Connected.")
--
2.31.1
- [PULL 00/32] Python patches, John Snow, 2021/09/27
- [PULL 01/32] python/aqmp: add asynchronous QMP (AQMP) subpackage, John Snow, 2021/09/27
- [PULL 02/32] python/aqmp: add error classes, John Snow, 2021/09/27
- [PULL 04/32] python/aqmp: add asyncio compatibility wrappers, John Snow, 2021/09/27
- [PULL 03/32] python/pylint: Add exception for TypeVar names ('T'), John Snow, 2021/09/27
- [PULL 07/32] python/aqmp: Add logging utility helpers, John Snow, 2021/09/27
- [PULL 05/32] python/aqmp: add generic async message-based protocol support, John Snow, 2021/09/27
- [PULL 06/32] python/aqmp: add runstate state machine to AsyncProtocol, John Snow, 2021/09/27
- [PULL 08/32] python/aqmp: add logging to AsyncProtocol, John Snow, 2021/09/27
- [PULL 10/32] python/aqmp: add configurable read buffer limit,
John Snow <=
- [PULL 11/32] python/aqmp: add _cb_inbound and _cb_outbound logging hooks, John Snow, 2021/09/27
- [PULL 12/32] python/aqmp: add AsyncProtocol._readline() method, John Snow, 2021/09/27
- [PULL 13/32] python/aqmp: add QMP Message format, John Snow, 2021/09/27
- [PULL 14/32] python/aqmp: add well-known QMP object models, John Snow, 2021/09/27
- [PULL 15/32] python/aqmp: add QMP event support, John Snow, 2021/09/27
- [PULL 16/32] python/pylint: disable too-many-function-args, John Snow, 2021/09/27
- [PULL 17/32] python/aqmp: add QMP protocol support, John Snow, 2021/09/27
- [PULL 18/32] python/pylint: disable no-member check, John Snow, 2021/09/27
- [PULL 19/32] python/aqmp: Add message routing to QMP protocol, John Snow, 2021/09/27
- [PULL 21/32] python/aqmp: add _raw() execution interface, John Snow, 2021/09/27