Re: [PATCH v6 12/40] accel/nvmm: Implement AccelOpsClass::has_work()

[Kamil Rytarowski]

On 24.09.2021 11:38, Philippe Mathieu-Daudé wrote:
> Since there is no specific NVMM handling for cpu_has_work() in
> cpu_thread_is_idle(), implement NVMM has_work() handler as a
> simple 'return false' code.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Kamil Rytarowski <n54@gmx.com>
> ---
>  target/i386/nvmm/nvmm-accel-ops.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/target/i386/nvmm/nvmm-accel-ops.c 
> b/target/i386/nvmm/nvmm-accel-ops.c
> index f788f75289f..36296f79ff8 100644
> --- a/target/i386/nvmm/nvmm-accel-ops.c
> +++ b/target/i386/nvmm/nvmm-accel-ops.c
> @@ -83,6 +83,11 @@ static void nvmm_kick_vcpu_thread(CPUState *cpu)
>      cpus_kick_thread(cpu);
>  }
>
> +static bool nvmm_cpu_has_work(CPUState *cpu)
> +{
> +    return false;
> +}
> +
>  static void nvmm_accel_ops_class_init(ObjectClass *oc, void *data)
>  {
>      AccelOpsClass *ops = ACCEL_OPS_CLASS(oc);
> @@ -94,6 +99,7 @@ static void nvmm_accel_ops_class_init(ObjectClass *oc, void 
> *data)
>      ops->synchronize_post_init = nvmm_cpu_synchronize_post_init;
>      ops->synchronize_state = nvmm_cpu_synchronize_state;
>      ops->synchronize_pre_loadvm = nvmm_cpu_synchronize_pre_loadvm;
> +    ops->has_work = nvmm_cpu_has_work;
>  }
>
>  static const TypeInfo nvmm_accel_ops_type = {
>