Re: [PATCH 1/1] virtio-gpu: CONTEXT_INIT feature

[Antonio Caggiano]

On 28/09/21 07:13, Gerd Hoffmann wrote:
> > @@ -212,6 +212,8 @@ virtio_gpu_base_get_features(VirtIODevice *vdev, uint64_t 
> > features,
> >           features |= (1 << VIRTIO_GPU_F_RESOURCE_BLOB);
> >       }
> >   
> > +    features |= (1 << VIRTIO_GPU_F_CONTEXT_INIT);
>
> This needs a config option, simliar to the other features.  It is a
> guest-visible change so we must be able to turn it off for live
> migration compatibility reasons.  We also need a compat property to
> turn it off by default for 6.1 + older machine types.

Could you give me a hint on how to add this compat property?



> > +    if (cc.context_init) {
> > +        virgl_renderer_context_create_with_flags(cc.hdr.ctx_id,
> > +                                                 cc.context_init,
> > +                                                 cc.nlen,
> > +                                                 cc.debug_name);
>
> This requires a minimum virglrenderer version I guess?


Definitely, that is going to be >= 0.9.0



> > --- a/include/standard-headers/linux/virtio_gpu.h
> > +++ b/include/standard-headers/linux/virtio_gpu.h
>
> Separate patch please.
> Also use scripts/update-linux-headers.sh for this.
Well, then I believe we will need to wait for this patch series:

https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg367531.html





Cheers,

Antonio