qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 05/25] linux-user/arm: Implement setup_sigtramp


From: Richard Henderson
Subject: Re: [PATCH v4 05/25] linux-user/arm: Implement setup_sigtramp
Date: Tue, 28 Sep 2021 08:28:39 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 9/28/21 5:31 AM, Peter Maydell wrote:
+        uint32_t *host_rc = g2h_untagged(retcode);

...but here we treat it as a normal guest address that we can
convert into a host address and dereference. If the signal handler
is being entered in Thumb mode this will be a misaligned pointer.

Oops, yes.

I've no idea why the kernel works so hard to match the mode of the signal handler to the mode of the trampoline, but I presume it's ABI at this point.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]