[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 8/9] migration/ram: Factor out populating pages readable i
|
From: |
Peter Xu |
|
Subject: |
Re: [PATCH v5 8/9] migration/ram: Factor out populating pages readable in ram_block_populate_pages() |
|
Date: |
Tue, 28 Sep 2021 11:34:22 -0400 |
On Sat, Sep 04, 2021 at 06:09:12PM +0200, David Hildenbrand wrote:
> Let's factor out prefaulting/populating to make further changes easier to
> review and add a comment what we are actually expecting to happen. While at
> it, use the actual page size of the ramblock, which defaults to
> qemu_real_host_page_size for anonymous memory. Further, rename
> ram_block_populate_pages() to ram_block_populate_read() as well, to make
> it clearer what we are doing.
>
> In the future, we might want to use MADV_POPULATE_READ to speed up
> population.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
- [PATCH v5 1/9] memory: Introduce replay_discarded callback for RamDiscardManager, (continued)
- [PATCH v5 1/9] memory: Introduce replay_discarded callback for RamDiscardManager, David Hildenbrand, 2021/09/04
- [PATCH v5 2/9] virtio-mem: Implement replay_discarded RamDiscardManager callback, David Hildenbrand, 2021/09/04
- [PATCH v5 3/9] migration/ram: Don't passs RAMState to migration_clear_memory_region_dirty_bitmap_*(), David Hildenbrand, 2021/09/04
- [PATCH v5 4/9] migration/ram: Handle RAMBlocks with a RamDiscardManager on the migration source, David Hildenbrand, 2021/09/04
- [PATCH v5 5/9] virtio-mem: Drop precopy notifier, David Hildenbrand, 2021/09/04
- [PATCH v5 6/9] migration/postcopy: Handle RAMBlocks with a RamDiscardManager on the destination, David Hildenbrand, 2021/09/04
- [PATCH v5 7/9] migration: Simplify alignment and alignment checks, David Hildenbrand, 2021/09/04
- [PATCH v5 8/9] migration/ram: Factor out populating pages readable in ram_block_populate_pages(), David Hildenbrand, 2021/09/04
- Re: [PATCH v5 8/9] migration/ram: Factor out populating pages readable in ram_block_populate_pages(),
Peter Xu <=
- [PATCH v5 9/9] migration/ram: Handle RAMBlocks with a RamDiscardManager on background snapshots, David Hildenbrand, 2021/09/04
- Re: [PATCH v5 0/9] migration/ram: Optimize for virtio-mem via RamDiscardManager, David Hildenbrand, 2021/09/28