Re: [PATCH v3 1/7] util/oslib-posix: Let touch_all_pages() return an error

[Daniel P . Berrangé]

On Mon, Aug 16, 2021 at 11:47:33AM +0200, David Hildenbrand wrote:
> Let's prepare touch_all_pages() for returning differing errors. Return
> an error from the thread and report the last processed error.
> 
> Translate SIGBUS to -EFAULT, as a SIGBUS can mean all different kind of
> things (memory error, read error, out of memory). When allocating memory
> fails via the current SIGBUS-based mechanism, we'll get:
>     os_mem_prealloc: preallocating memory failed: Bad address
> 
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
>  util/oslib-posix.c | 28 ++++++++++++++++------------
>  1 file changed, 16 insertions(+), 12 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|