[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/3] hw/char/mchp_pfsoc_mmuart: Simplify MCHP_PFSOC_MMUART
From: |
Alistair Francis |
Subject: |
Re: [PATCH v2 1/3] hw/char/mchp_pfsoc_mmuart: Simplify MCHP_PFSOC_MMUART_REG definition |
Date: |
Wed, 29 Sep 2021 08:19:33 +1000 |
On Sun, Sep 26, 2021 at 6:31 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Sat, Sep 25, 2021 at 9:34 PM Philippe Mathieu-Daudé <f4bug@amsat.org>
> wrote:
> >
> > The current MCHP_PFSOC_MMUART_REG_SIZE definition represent the
> > size occupied by all the registers. However all registers are
> > 32-bit wide, and the MemoryRegionOps handlers are restricted to
> > 32-bit:
> >
> > static const MemoryRegionOps mchp_pfsoc_mmuart_ops = {
> > .read = mchp_pfsoc_mmuart_read,
> > .write = mchp_pfsoc_mmuart_write,
> > .impl = {
> > .min_access_size = 4,
> > .max_access_size = 4,
> > },
> >
> > Avoid being triskaidekaphobic, simplify by using the number of
>
> typo? See https://www.dictionary.com/browse/triskaidekaphobia
>
> Learned a new word today but I have to say this word is too hard for a
> non-native speaker :)
Ha! Even as a native English speaker I had to look it up :)
Alistair