Re: [PATCH v3 0/2] modules: Improve modinfo.c support

[Gerd Hoffmann]

On Tue, Sep 28, 2021 at 05:46:26PM -0300, Jose R. Ziviani wrote:
> This patchset introduces the modinfo_kconfig aiming for a fine-tune
> control of module loading by simply checking Kconfig options during the
> compile time, then generates one modinfo-<target>-softmmu.c per target.
> 
> The main reason of this change is to fix problems like:
> $ ./qemu-system-s390x -nodefaults -display none -accel tcg -M none -device 
> help | head
> Failed to open module: /.../hw-display-qxl.so: undefined symbol: 
> vga_ioport_read
> Failed to open module: /.../hw-display-virtio-vga.so: undefined symbol: 
> vmstate_vga_common
> Failed to open module: /.../hw-display-virtio-vga.so: undefined symbol: 
> vmstate_vga_common
> Failed to open module: /.../hw-display-virtio-vga-gl.so: undefined symbol: 
> have_vga
> Failed to open module: /.../hw-usb-smartcard.so: undefined symbol: 
> ccid_card_ccid_attach
> Failed to open module: /.../hw-usb-redirect.so: undefined symbol: 
> vmstate_usb_device
> Failed to open module: /.../hw-usb-host.so: undefined symbol: 
> vmstate_usb_device
> 
> With this patch, I run this small script successfuly:
>     #!/bin/bash
>     pushd ~/suse/virtualization/qemu/build
>     for qemu in qemu-system-*
>     do
>         [[ -f "$qemu" ]] || continue
>         res=$(./$qemu -nodefaults -display none -accel tcg -M none -device 
> help 2>&1 | grep "Failed to" > /dev/null; echo $?)
>         [[ $res -eq 0 ]] && echo "Error: $qemu"
>     done
>     popd
> 
> Also run 'make check' and 'check-acceptance' without any failures.

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd