qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v8 36/40] target/sparc: Restrict has_work() handler to sysemu


From: Mark Cave-Ayland
Subject: Re: [PATCH v8 36/40] target/sparc: Restrict has_work() handler to sysemu
Date: Wed, 29 Sep 2021 08:07:18 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0

On 26/09/2021 23:27, Philippe Mathieu-Daudé wrote:

Restrict has_work() to sysemu.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
  target/sparc/cpu.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c
index 0d252cb5bdc..8d61bf15f6c 100644
--- a/target/sparc/cpu.c
+++ b/target/sparc/cpu.c
@@ -702,6 +702,7 @@ static void sparc_cpu_synchronize_from_tb(CPUState *cs,
      cpu->env.npc = tb->cs_base;
  }
+#if !defined(CONFIG_USER_ONLY)
  static bool sparc_cpu_has_work(CPUState *cs)
  {
      SPARCCPU *cpu = SPARC_CPU(cs);
@@ -710,6 +711,7 @@ static bool sparc_cpu_has_work(CPUState *cs)
      return (cs->interrupt_request & CPU_INTERRUPT_HARD) &&
             cpu_interrupts_enabled(env);
  }
+#endif /* !CONFIG_USER_ONLY */
static char *sparc_cpu_type_name(const char *cpu_model)
  {
@@ -867,6 +869,7 @@ static const struct TCGCPUOps sparc_tcg_ops = {
      .tlb_fill = sparc_cpu_tlb_fill,
#ifndef CONFIG_USER_ONLY
+    .has_work = sparc_cpu_has_work,
      .cpu_exec_interrupt = sparc_cpu_exec_interrupt,
      .do_interrupt = sparc_cpu_do_interrupt,
      .do_transaction_failed = sparc_cpu_do_transaction_failed,
@@ -888,7 +891,6 @@ static void sparc_cpu_class_init(ObjectClass *oc, void 
*data)
cc->class_by_name = sparc_cpu_class_by_name;
      cc->parse_features = sparc_cpu_parse_features;
-    cc->has_work = sparc_cpu_has_work;
      cc->dump_state = sparc_cpu_dump_state;
  #if !defined(TARGET_SPARC64) && !defined(CONFIG_USER_ONLY)
      cc->memory_rw_debug = sparc_cpu_memory_rw_debug;

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]