qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] virtio-net : Add check for VIRTIO_NET_F_MAC


From: Michael Tokarev
Subject: Re: [PATCH] virtio-net : Add check for VIRTIO_NET_F_MAC
Date: Thu, 30 Sep 2021 13:46:09 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0

30.09.2021 04:35, Cindy Lu wrote:
[]
so here come to the final question. which mac address has the higher priority?
I think the NET_F_MAC bit means the hw mac address > command-line address.
if the hw drivers want to change this. they can simply remove this bit.

At the very least, qemu should NEVER silently ignore stuff specified
on the command line. It should either warn the user or error out if
command-line parameter can not be applied for whatever reason.

I don't know the context, what NET_F_MAC is, but the general rule is
this: if the user specified something, it must not be ignored.

/mjt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]