[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/7] docs: name included files ".rst.inc"
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH 1/7] docs: name included files ".rst.inc" |
|
Date: |
Thu, 30 Sep 2021 15:47:46 +0100 |
On Thu, 30 Sept 2021 at 14:33, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> --- a/docs/devel/ci.rst
> +++ b/docs/devel/ci.rst
> @@ -8,6 +8,6 @@ found at::
>
> https://wiki.qemu.org/Testing/CI
>
> -.. include:: ci-definitions.rst
> -.. include:: ci-jobs.rst
> -.. include:: ci-runners.rst
> +.. include:: ci-definitions.rst.inc
> +.. include:: ci-jobs.rst.inc
> +.. include:: ci-runners.rst.inc
Why are these includes anyway? I think we should either make them
proper separate documents (pulled in via a toctree), or just fold
the whole thing into a single file if we think it should only be
one page. I think it's probably better to reserve the include
directive for places where we really do need to textually pull in
another file, ie where we have the same text in several documents.
thanks
-- PMM