[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 13/22] target/arm: Fix coding style issues in gdbstub code in help
From: |
Peter Maydell |
Subject: |
[PULL 13/22] target/arm: Fix coding style issues in gdbstub code in helper.c |
Date: |
Thu, 30 Sep 2021 16:11:52 +0100 |
We're going to move this code to a different file; fix the coding
style first so checkpatch doesn't complain. This includes deleting
the spurious 'break' statements after returns in the
vfp_gdb_get_reg() function.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20210921162901.17508-3-peter.maydell@linaro.org
---
target/arm/helper.c | 23 ++++++++++++++++-------
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/target/arm/helper.c b/target/arm/helper.c
index 62742214473..84bba9a2244 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -72,9 +72,12 @@ static int vfp_gdb_get_reg(CPUARMState *env, GByteArray
*buf, int reg)
}
}
switch (reg - nregs) {
- case 0: return gdb_get_reg32(buf, env->vfp.xregs[ARM_VFP_FPSID]); break;
- case 1: return gdb_get_reg32(buf, vfp_get_fpscr(env)); break;
- case 2: return gdb_get_reg32(buf, env->vfp.xregs[ARM_VFP_FPEXC]); break;
+ case 0:
+ return gdb_get_reg32(buf, env->vfp.xregs[ARM_VFP_FPSID]);
+ case 1:
+ return gdb_get_reg32(buf, vfp_get_fpscr(env));
+ case 2:
+ return gdb_get_reg32(buf, env->vfp.xregs[ARM_VFP_FPEXC]);
}
return 0;
}
@@ -98,9 +101,15 @@ static int vfp_gdb_set_reg(CPUARMState *env, uint8_t *buf,
int reg)
}
}
switch (reg - nregs) {
- case 0: env->vfp.xregs[ARM_VFP_FPSID] = ldl_p(buf); return 4;
- case 1: vfp_set_fpscr(env, ldl_p(buf)); return 4;
- case 2: env->vfp.xregs[ARM_VFP_FPEXC] = ldl_p(buf) & (1 << 30); return 4;
+ case 0:
+ env->vfp.xregs[ARM_VFP_FPSID] = ldl_p(buf);
+ return 4;
+ case 1:
+ vfp_set_fpscr(env, ldl_p(buf));
+ return 4;
+ case 2:
+ env->vfp.xregs[ARM_VFP_FPEXC] = ldl_p(buf) & (1 << 30);
+ return 4;
}
return 0;
}
@@ -119,7 +128,7 @@ static int aarch64_fpu_gdb_get_reg(CPUARMState *env,
GByteArray *buf, int reg)
return gdb_get_reg32(buf, vfp_get_fpsr(env));
case 33:
/* FPCR */
- return gdb_get_reg32(buf,vfp_get_fpcr(env));
+ return gdb_get_reg32(buf, vfp_get_fpcr(env));
default:
return 0;
}
--
2.20.1
- [PULL 03/22] hw/nvram: Introduce Xilinx eFuse QOM, (continued)
- [PULL 03/22] hw/nvram: Introduce Xilinx eFuse QOM, Peter Maydell, 2021/09/30
- [PULL 05/22] hw/nvram: Introduce Xilinx ZynqMP eFuse device, Peter Maydell, 2021/09/30
- [PULL 04/22] hw/nvram: Introduce Xilinx Versal eFuse device, Peter Maydell, 2021/09/30
- [PULL 10/22] hw/arm: xlnx-zcu102: Add Xilinx eFUSE device, Peter Maydell, 2021/09/30
- [PULL 12/22] configs: Don't include 32-bit-only GDB XML in aarch64 linux configs, Peter Maydell, 2021/09/30
- [PULL 09/22] hw/arm: xlnx-zcu102: Add Xilinx BBRAM device, Peter Maydell, 2021/09/30
- [PULL 06/22] hw/nvram: Introduce Xilinx battery-backed ram, Peter Maydell, 2021/09/30
- [PULL 07/22] hw/arm: xlnx-versal-virt: Add Xilinx BBRAM device, Peter Maydell, 2021/09/30
- [PULL 08/22] hw/arm: xlnx-versal-virt: Add Xilinx eFUSE device, Peter Maydell, 2021/09/30
- [PULL 11/22] docs/system/arm: xlnx-versal-virt: BBRAM and eFUSE Usage, Peter Maydell, 2021/09/30
- [PULL 13/22] target/arm: Fix coding style issues in gdbstub code in helper.c,
Peter Maydell <=
- [PULL 17/22] ipack: Rename ipack_bus_new_inplace() to ipack_bus_init(), Peter Maydell, 2021/09/30
- [PULL 14/22] target/arm: Move gdbstub related code out of helper.c, Peter Maydell, 2021/09/30
- [PULL 18/22] pci: Rename pci_root_bus_new_inplace() to pci_root_bus_init(), Peter Maydell, 2021/09/30
- [PULL 19/22] qbus: Rename qbus_create_inplace() to qbus_init(), Peter Maydell, 2021/09/30
- [PULL 22/22] hw/arm: sabrelite: Connect SPI flash CS line to GPIO3_19, Peter Maydell, 2021/09/30
- [PULL 21/22] ide: Rename ide_bus_new() to ide_bus_init(), Peter Maydell, 2021/09/30
- [PULL 15/22] target/arm: Don't put FPEXC and FPSID in org.gnu.gdb.arm.vfp XML, Peter Maydell, 2021/09/30
- [PULL 16/22] scsi: Replace scsi_bus_new() with scsi_bus_init(), scsi_bus_init_named(), Peter Maydell, 2021/09/30
- [PULL 20/22] qbus: Rename qbus_create() to qbus_new(), Peter Maydell, 2021/09/30