[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/9] fsdev: Add missing definitions for Windows in file-op-9p
From: |
Christian Schoenebeck |
Subject: |
Re: [PATCH 4/9] fsdev: Add missing definitions for Windows in file-op-9p.h |
Date: |
Wed, 04 May 2022 19:35:57 +0200 |
On Montag, 25. April 2022 16:27:00 CEST Bin Meng wrote:
> From: Guohuai Shi <guohuai.shi@windriver.com>
>
> Add uid_t, gid_t and struct statfs definitions, which are currently
> missing from Windows headers, but are required when we add 9p file
> system support for Windows in later patches.
>
> Signed-off-by: Guohuai Shi <guohuai.shi@windriver.com>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> ---
>
> fsdev/file-op-9p.h | 33 +++++++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/fsdev/file-op-9p.h b/fsdev/file-op-9p.h
> index 4997677460..7d9a736b66 100644
> --- a/fsdev/file-op-9p.h
> +++ b/fsdev/file-op-9p.h
> @@ -27,6 +27,39 @@
> # include <sys/mount.h>
> #endif
>
> +#ifdef CONFIG_WIN32
> +
> +/* POSIX structure not defined in Windows */
> +
> +typedef uint32_t uid_t;
> +typedef uint32_t gid_t;
> +
> +/* from http://man7.org/linux/man-pages/man2/statfs.2.html */
> +typedef uint32_t __fsword_t;
> +typedef uint32_t fsblkcnt_t;
> +typedef uint32_t fsfilcnt_t;
> +
> +/* from linux/include/uapi/asm-generic/posix_types.h */
> +typedef struct {
> + long __val[2];
> +} fsid_t;
> +
> +struct statfs {
> + __fsword_t f_type;
> + __fsword_t f_bsize;
> + fsblkcnt_t f_blocks;
> + fsblkcnt_t f_bfree;
> + fsblkcnt_t f_bavail;
> + fsfilcnt_t f_files;
> + fsfilcnt_t f_ffree;
> + fsid_t f_fsid;
> + __fsword_t f_namelen;
> + __fsword_t f_frsize;
> + __fsword_t f_flags;
> +};
> +
> +#endif /* CONFIG_WIN32 */
> +
> #define SM_LOCAL_MODE_BITS 0600
> #define SM_LOCAL_DIR_MODE_BITS 0700
I don't think this header file is the right place to add these missing POSIX
types. I would add them to 9p-util-windows.h or something like that.
Best regards,
Christian Schoenebeck
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH 4/9] fsdev: Add missing definitions for Windows in file-op-9p.h,
Christian Schoenebeck <=