[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] checkpatch: fix g_malloc check
From: |
Paolo Bonzini |
Subject: |
[PATCH] checkpatch: fix g_malloc check |
Date: |
Wed, 4 May 2022 22:31:29 +0200 |
Use the string equality operator "eq", and ensure that $1 is defined by
using "(try|)" instead of "(try)?". The alternative "((?:try)?)" is
longer and less readable.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
scripts/checkpatch.pl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 4763d02ae7..d900d18048 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2831,8 +2831,8 @@ sub process {
}
# check for pointless casting of g_malloc return
- if ($line =~ /\*\s*\)\s*g_(try)?(m|re)alloc(0?)(_n)?\b/) {
- if ($2 == 'm') {
+ if ($line =~ /\*\s*\)\s*g_(try|)(m|re)alloc(0?)(_n)?\b/) {
+ if ($2 eq 'm') {
ERROR("unnecessary cast may hide bugs, use
g_$1new$3 instead\n" . $herecurr);
} else {
ERROR("unnecessary cast may hide bugs, use
g_$1renew$3 instead\n" . $herecurr);
--
2.35.1
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [PATCH] checkpatch: fix g_malloc check,
Paolo Bonzini <=