Re: [PATCH 1/5] slirp: bump submodule to 4.7 release

[Paolo Bonzini]

On Thu, May 5, 2022 at 10:21 AM Marc-André Lureau
<marcandre.lureau@gmail.com> wrote:
>
>
>
> On Thu, May 5, 2022 at 1:06 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> Version 4.7 of slirp provides a new timer API that works better with CFI,
>> together with several other improvements:
>>
>> * Allow disabling the internal DHCP server !22
>> * Support Unix sockets in hostfwd !103
>> * IPv6 DNS proxying support !110
>> * bootp: add support for UEFI HTTP boot !111
>>
>> and bugfixes.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Unfortunately this fails to build on Windows due to a libslirp bug
(https://gitlab.freedesktop.org/slirp/libslirp/-/merge_requests/121).
We could include the couple extra commits in QEMU, since there are no
other changes to libslirp since 4.7.0 and they only fix a compiler
warning; or wait for 4.7.1 to be released; or resuscitate the patches
that switch libslirp to a subproject, but that's my least favorite
because we're going to remove the bundled source code anyway sooner or
later.

Paolo