Re: [PATCH 0/3] artist: minor fixes and performance improvement

[Helge Deller]

On 5/4/22 17:37, Mark Cave-Ayland wrote:
> Patch 1 updates artist.c to fix some style issues and ensure that artist.c 
> passes
> checkpatch for the remainder of the patchset, whilst patch 2 removes the 
> ROP8OFF()
> macro which is currently unused.
>
> Finally patch 3 is the main reason for this patchset and improves the 
> performance
> of the artist framebuffer by only rendering the dirty scanlines to the display
> surface, which noticeably improves boot times and makes the GTK UI usable on 
> my
> fairly modest laptop.
>
> [Helge/Sven: if you can provide a Tested-by or Reviewed-by tag for this 
> patchset
> before the weekend, I can include it in my PR containing all the other HPPA
> updates]
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

I tested it and indeed, the GTK GUI is now really much faster, even with the
GTK window forwarded over X11.

Ideally, can the patch #3 (the GTK speedup) be backported?

I applied, reviewed and tested it. Please add:

Reviewed-by: Helge Deller <deller@gmx.de>

Thanks!
Helge


>
> Mark Cave-Ayland (3):
>   artist: checkpatch and newline style fixes
>   artist: remove unused ROP8OFF() macro
>   artist: only render dirty scanlines on the display surface
>
>  hw/display/artist.c | 33 ++++++++++++++-------------------
>  1 file changed, 14 insertions(+), 19 deletions(-)
>