Re: [PATCH v2 39/50] lasi: use constants for device register offsets

[Mark Cave-Ayland]

On 08/05/2022 04:04, Richard Henderson wrote:

> On 5/4/22 04:25, Mark Cave-Ayland wrote:
> > Instead of generating the offset based upon the physical address of the
> > register, add constants for each of the device registers to lasi.h and
> > update lasi.c to use them.
> >
> > Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> > Acked-by: Helge Deller <deller@gmx.de>
> > ---
> >   hw/hppa/lasi.c | 28 ++++++++++++++--------------
> >   hw/hppa/lasi.h |  5 +++++
> >   2 files changed, 19 insertions(+), 14 deletions(-)
>
> Worth removing the final usages, and the old definitions in hppa_machine.h?
>
> Otherwise,
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

I did think about that, but then there are a few devices I can think of where there 
are additional comments/definitions from an external header included for reference.

My feeling for a patch like this (which is really just moving towards modern APIs) is 
to leave this for the maintainer, particularly as for people less familiar with QEMU 
they find it easier to use the physical address rather than work with memory region 
offsets.


ATB,

Mark.