[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] qom/object: Remove circular include dependency
From: |
Markus Armbruster |
Subject: |
Re: [PATCH] qom/object: Remove circular include dependency |
Date: |
Mon, 09 May 2022 11:52:50 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> writes:
> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> "qom/object.h" doesn't need to include itself.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> include/qom/object.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/qom/object.h b/include/qom/object.h
> index 5f3d5b5bf5..ef7258a5e1 100644
> --- a/include/qom/object.h
> +++ b/include/qom/object.h
> @@ -16,7 +16,6 @@
>
> #include "qapi/qapi-builtin-types.h"
> #include "qemu/module.h"
> -#include "qom/object.h"
>
> struct TypeImpl;
> typedef struct TypeImpl *Type;
I figure this is scripts/codeconverter/converter.py's doing, in commit
db1015e92e "Move QOM typedefs and add missing includes". Probably not
worth fixing there. Possibly worth mentioning in the commit message.
Reviewed-by: Markus Armbruster <armbru@redhat.com>